feat(code-mappings): Wire up API integration for code-mappings upload by romtsn · Pull Request #3209 · getsentry/sentry-cli

romtsn · 2026-03-12T09:07:46Z

#skip-changelog

Connect the code-mappings upload command to the bulk code mappings API
endpoint (POST /api/0/organizations/{org}/code-mappings/bulk/).

Adds:

bulk_upload_code_mappings() method on AuthenticatedApi
Request/response data types in src/api/data_types/code_mappings.rs
Summary table and error reporting in the command output
Happy-path integration test with mock endpoint

Stack: #3207 → #3208 → #3209 → #3210

Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786

Closes getsentry/sentry-android-gradle-plugin#1079

github-actions · 2026-03-12T09:08:17Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a008901

Add a new `code-mappings` subcommand group with an `upload` subcommand that reads and validates a JSON file of code mappings. This is the first step toward CLI support for bulk code mapping uploads to Sentry.

szokeasaurusrex

lgtm, added some minor optional improvements

src/commands/code_mappings/upload.rs

Add descriptive help text explaining what code mappings are and how they work. Replace unwrap with expect for the required path argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Automatically detect repository name and default branch from the local git repo when --repo or --default-branch are not provided. Respects SENTRY_VCS_REMOTE config, falling back to best-effort remote detection. Extract find_best_remote() into vcs.rs to deduplicate remote selection logic shared with git_repo_base_repo_name_preserve_case().

When --repo is provided but --default-branch is not, the code no longer requires a git remote to be present. Branch inference gracefully falls back to 'main' when no git repo or remote is available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use get_repo_from_remote_preserve_case instead of get_repo_from_remote to avoid lowercasing the repository name, which would cause mismatches with Sentry's case-sensitive API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add bulk_upload_code_mappings() API method and BulkCodeMappingsRequest/ Response data types. Wire up the upload command to authenticate, call the bulk endpoint, and display results in a table with summary counts. Exit with code 1 if any mappings fail.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

src/api/mod.rs

The bulk code-mappings endpoint is scoped to an organization, so a 404 should report "organization not found" rather than generic "resource not found", consistent with other org-scoped endpoints. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Simplify the status match per review feedback and extract the table building logic into a print_results_table function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

szokeasaurusrex

🚀

szokeasaurusrex · 2026-03-19T12:53:02Z

src/api/data_types/code_mappings.rs

+    pub repository: String,
+    pub default_branch: String,
+    pub mappings: Vec<BulkCodeMapping>,
+}


m: Because of how we use this in #3210, I think this struct should probably use borrowed, instead of owned, types. This would avoid cloning in #3210

pub struct BulkCodeMappingsRequest<'a> { pub project: &'a str, pub repository: &'a str, pub default_branch: &'a str, pub mappings: &'a [BulkCodeMapping], }

_#skip-changelog_ Add the `sentry-cli code-mappings upload` subcommand group and the `upload` subcommand with file parsing and validation. This is the first in a stack of 4 PRs to support bulk uploading code mappings from a JSON file — useful for Java/Android multi-module projects that need dozens of mappings. This PR adds: - Command scaffold following the `repos`/`deploys` pattern - JSON file reading and validation (empty arrays, empty stackRoot/sourceRoot) - CLI args: positional `PATH`, `--repo`, `--default-branch` - Help and no-subcommand trycmd integration tests Stack: **#3207** → #3208 → #3209 → #3210 Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786 Closes getsentry/sentry-android-gradle-plugin#1076 Closes getsentry/sentry-android-gradle-plugin#1077 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

feat(cli): Add code-mappings upload command scaffold with file parsing

029aeaf

Add a new `code-mappings` subcommand group with an `upload` subcommand that reads and validates a JSON file of code mappings. This is the first step toward CLI support for bulk code mapping uploads to Sentry.

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 684caab to 912da39 Compare March 12, 2026 10:55

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from f5ab182 to 37fbb57 Compare March 12, 2026 10:55

This was referenced Mar 12, 2026

feat(code-mappings): Add code-mappings upload command scaffold #3207

Merged

feat(code-mappings): Add git inference for repo and default branch #3208

Open

feat(code-mappings): Add batch splitting for large uploads #3210

Open

fix(test): Update help snapshots with code-mappings subcommand

072fa6b

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 37fbb57 to 5720ec2 Compare March 12, 2026 11:11

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 912da39 to 95e8814 Compare March 12, 2026 11:11

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 5720ec2 to bbc4d47 Compare March 12, 2026 11:30

romtsn marked this pull request as ready for review March 18, 2026 11:44

romtsn requested review from a team and szokeasaurusrex as code owners March 18, 2026 11:44

szokeasaurusrex approved these changes Mar 18, 2026

View reviewed changes

src/commands/code_mappings/upload.rs Show resolved Hide resolved

src/commands/code_mappings/upload.rs Outdated Show resolved Hide resolved

src/commands/code_mappings/upload.rs Show resolved Hide resolved

romtsn and others added 6 commits March 18, 2026 17:52

fix(code-mappings): Address PR feedback on help text and unwrap usage

8acfdbe

Add descriptive help text explaining what code mappings are and how they work. Replace unwrap with expect for the required path argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix(code-mappings): Update top-level help snapshot for new description

1015af1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix(code-mappings): Update Windows help snapshot for new description

811bb94

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

style: Fix formatting in code-mappings upload

154502b

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from e405066 to 8f9babe Compare March 18, 2026 17:15

romtsn and others added 3 commits March 18, 2026 18:41

style: Fix formatting in upload test

e288070

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 3d14593 to e288070 Compare March 18, 2026 17:54

cursor bot reviewed Mar 18, 2026

View reviewed changes

src/api/mod.rs Outdated Show resolved Hide resolved

romtsn and others added 2 commits March 18, 2026 21:04

ref(code-mappings): Simplify result display and extract table helper

a008901

Simplify the status match per review feedback and extract the table building logic into a print_results_table function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

szokeasaurusrex approved these changes Mar 19, 2026

View reviewed changes

szokeasaurusrex reviewed Mar 19, 2026

View reviewed changes

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 70ddd86 to 6dae115 Compare March 20, 2026 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(code-mappings): Wire up API integration for code-mappings upload#3209

feat(code-mappings): Wire up API integration for code-mappings upload#3209
romtsn wants to merge 13 commits intorz/feat/code-mappings-git-inferencefrom
rz/feat/code-mappings-api-integration

romtsn commented Mar 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

szokeasaurusrex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Uh oh!

szokeasaurusrex Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

romtsn commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

szokeasaurusrex Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

romtsn commented Mar 12, 2026 •

edited

Loading

github-actions bot commented Mar 12, 2026 •

edited

Loading